Upgrade data-plane-api#39
Merged
kyessenov merged 8 commits intoenvoyproxy:masterfrom Feb 5, 2018
Merged
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
zuercher
approved these changes
Feb 5, 2018
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
I'm not particularly expert in the pkg/* code, but it's most package renaming. LGTM.
Contributor
Author
|
Yes, there's no functional change. Only alignment with data-plane-api packaging hierarchy. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates data-plane-api to take in package re-organization in data-plane-api.
IMPORTANT: this is a breaking change since package paths have changed, and hopefully stabilized. I have verified that the latest Envoy should work end-to-end with this change. It should be an easy update to fix the clients since the proto content is stable, and only import paths need to be modified.
Requires the following PRs to be merged:
Minor improvements to code generation using gogoproto annotations.
cc @davecheney @crazytan @bndw @joyeb @junr03 @rshriram (any other folks that I missed)