Address the last few ambiguous Envoy includes#129
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Aug 27, 2019
Merged
Conversation
Re-route the last few include that couldn't go via `external/envoy/...` earler, plus some cleanup. Needed for envoyproxy#119 This needs envoyproxy/envoy#8045 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
This pulls in envoyproxy/envoy#8045 which we need for this to work Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Member
Author
|
Updated our Envoy dependency, with that CI is passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adresses the last ambiguous includes paths, and contains some cleanup.
Needed for #119
This needs envoyproxy/envoy#8045
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com