Update Envoy to 95038fe (Aug 12th 2021).#734
Merged
Merged
Conversation
Signed-off-by: Jakub Sobon <mumak@google.com>
Moving it from `process_impl.cc` into `process_bootstrap.cc`. Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Bootstrap is now generated at ProcessImpl construction time. Also shutdown the process when the named constructor fails. Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
dubious90
previously approved these changes
Aug 18, 2021
Signed-off-by: Jakub Sobon <mumak@google.com>
dubious90
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProcessImpl, creating a named constructor that allows us tocreate bootstrap initially and pass it to
Envoy::Api::Impl()as requiredsince Buffer Factory: Configuration of the minimum account size to track. envoy#17562. Specifically:
ProcessImpl::determineConcurrency()out of the ProcessImpl class so that it can be used during its construction.process_impl.ccintoprocess_bootstrap.cc.CreatesBootstrapForH1RespectingPortInUriintoprocess_bootstrap_test.cc.ProcessImplthat creates theEnvoy::Api::Apiwith an empty Bootstrap that is then replaced with the one generated. See an inline comment for explanation.ProcessImplprivate..bazelrc,.bazelversion,run_envoy_docker.sh.