Update Envoy to 5d4a457 (Oct 19, 2021)#754
Merged
dubious90 merged 5 commits intoenvoyproxy:mainfrom Oct 19, 2021
Merged
Conversation
…bazelversion, commit id and SHA Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
oschaaf
previously approved these changes
Oct 19, 2021
Member
oschaaf
left a comment
oschaaf
left a comment
There was a problem hiding this comment.
Aside of the clang-tidy complaint, this LGTM
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
oschaaf
approved these changes
Oct 19, 2021
dubious90
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.bazelrc.bazelversionProcessImplreceives an injected DNS resolver factory instead of a DNS resolver is that the complicatedApithe factory needs to work is only constructed later (in theProcessImplconstructor).createDefaultDnsResolverFactory()creates the platform-specific factory and also has the side effect of populating theTypedExtensionConfig.createDnsResolver()method on the DNS resolver factory also takes theTypedExtensionConfigas an input. So in addition to injecting the factory intoProcessImpl, we also need to inject theTypedExtensionConfigthat was populated bycreateDefaultDnsResolverFactory().