(fixes): local cache stat test fixes#1013
Merged
collin-lee merged 2 commits intoenvoyproxy:mainfrom Dec 3, 2025
Merged
Conversation
Signed-off-by: Sagar Waidande <sagar10018233@gmail.com>
…nfig local cache stat tests Signed-off-by: Sagar Waidande <sagar10018233@gmail.com>
sagarsuperuser
force-pushed
the
fix/tests
branch
from
d964698 to
9c1f0cf
Compare
collin-lee
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the issue
testLocalCacheStats never ran, the store used a null sink, expected counts were off, and assertions cast to the wrong types, so local cache metrics weren’t actually validated.
Fixes
Run testLocalCacheStats as subtests in each scenario, wire gostats.NewStore to TestStatSink so stats are flushed and visible, correct the expected hit/miss/lookup/expired/entry counts, and assert using uint64 to match emitted metrics.