implement quota mode for soft rate limit check#1045
Merged
collin-lee merged 5 commits intoenvoyproxy:mainfrom Jan 15, 2026
Merged
implement quota mode for soft rate limit check#1045collin-lee merged 5 commits intoenvoyproxy:mainfrom
collin-lee merged 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
yanavlasov
approved these changes
Jan 14, 2026
Contributor
|
Looks good to me. Thanks. @collin-lee will wait for your review as well, since you were reviewing latest PRs. Note this change is to support Quota for Envoy AI Gateway envoyproxy/ai-gateway#1571 The difference from the existing rate limit logic, is that in quota mode request is allowed if any of the descriptors have quota. Quota mode would be enabled at the domain level. I.e. all descriptors under a specific domain will either be in quota or rate limit mode. /wait-any |
collin-lee
approved these changes
Jan 14, 2026
This was referenced Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the quota mode soft limit feature for rate limiting service.
Use Cases:
example test:
{"overallCode":"OK", "statuses":[{"code":"OK", "currentLimit":{"requestsPerUnit":3, "unit":"MINUTE"}}], "dynamicMetadata":{"descriptors":[{"entries":["quota_limit=test"]}], "domain":"test_domain", "quotaModeEnabled":true, "quotaModeViolations":[0]}}