Fix data race issue in globalShadowMode variable#370
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Nov 4, 2022
Merged
Fix data race issue in globalShadowMode variable#370mattklein123 merged 2 commits intoenvoyproxy:mainfrom
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
Conversation
globalShadowMode is written when config is reloaded and read in here, which may lead to data race condition Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
mattklein123
approved these changes
Nov 4, 2022
barroca
pushed a commit
to barroca/ratelimit
that referenced
this pull request
Sep 1, 2023
globalShadowMode is written when config is reloaded and read in here, which may lead to data race condition Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
timcovar
pushed a commit
to goatapp/ratelimit
that referenced
this pull request
Jan 16, 2024
globalShadowMode is written when config is reloaded and read in here, which may lead to data race condition Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GlobalShadowMode is written when the config is reloaded from environment variables
ratelimit/src/service/ratelimit.go
Line 84 in 7b60ac7
And it is read here
ratelimit/src/service/ratelimit.go
Line 231 in 7b60ac7
which may lead to a data race condition