Dynamic config update via xDS Management Server by renuka-fernando · Pull Request #373 · envoyproxy/ratelimit

renuka-fernando · 2022-10-25T17:51:50Z

Description

Fix #201

Design

Provider Interface: How can I use the ratelimit setting dynamically? #201 (comment)
Configurations: How can I use the ratelimit setting dynamically? #201 (comment)

Tasks

Unit Tests
Integration Tests
An example xDS server - within docker-compose-example setup
Doc update for configs

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com> Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

…content string Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

carnei-ro · 2022-12-09T11:58:04Z

Having a controller to handle the RateLimit configurations would be really nice!

…ds-conf-provider-impl Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com> Conflicts: go.sum src/config/config_impl.go

github-actions · 2023-01-12T08:06:40Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

…ds-conf-provider-impl Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com> Conflicts: go.sum

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

renuka-fernando · 2023-01-27T17:01:46Z

Hi @mattklein123,

ADS Client implementation is merged envoyproxy/go-control-plane#604 and updated the go-control-plane version to reflect the client implementation. Could you please review this PR?

Thanks.

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

mattklein123

Nice. I skimmed and in general LGTM. Fine to ship and iterate with the small nit fix, thanks.

envoyproxy#373 (comment) Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Related to envoyproxy#371 Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

mattklein123

Thanks!

collinlee · 2023-04-01T06:28:26Z

@alecholmez - is there a resource somewhere that shows how to use the dynamic config updates via xDS to update envoy ratelimit configuration?

renuka-fernando · 2023-04-02T02:03:13Z

@alecholmez - is there a resource somewhere that shows how to use the dynamic config updates via xDS to update envoy ratelimit configuration?

Here is an example xDS server that will update the configuration of the rate limit service https://github.com/envoyproxy/ratelimit/tree/main/examples/xds-sotw-config-server.

If you want to configure envoy, refer to this doc https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/other_features/global_rate_limiting.
Route configuration: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-field-config-route-v3-virtualhost-rate-limits.

collinlee · 2023-04-02T04:02:37Z

Thank you!

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

renuka-fernando added 16 commits October 11, 2022 08:33

Move runtime file watcher from server to file provider

c24b743

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Update unit tests of service

7aeb1e8

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Add xDS config proto files

df1e1b4

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Move provider to a new package from config package

c87441c

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Add config xDS client

dd9a703

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Remove runtime usage in service

9b3d09e

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Add unit tests for xDS config provider

a3adcc9

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Add integration tests for xDS config provider

a94b006

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Add integration tests for xDS config reload

e1f0ece

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Enable TLS for xDS configuration client

6ad7ad8

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Add sample xDS sever

2cf48fa

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Separate the logic that converts string format of config file to yaml

e9e2a9e

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com> Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Convert xDS proto to yaml and use yaml as the config instead of file …

2ba99f9

…content string Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Add RateLimitUnit enum in rate limit config xDS proto

943907a

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Add unit tests for test domain merge functionality

0955383

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Update docs for rate limit xDS config management service

be6c107

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

renuka-fernando mentioned this pull request Oct 25, 2022

Add gRPC proto def for rate-limit xDS Config communication #371

Closed

renuka-fernando force-pushed the xds-conf-provider-impl branch from e8e9494 to dc3d1ed Compare November 2, 2022 09:13

Using ADS client from GCP

b591364

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

renuka-fernando force-pushed the xds-conf-provider-impl branch from dc3d1ed to b591364 Compare November 2, 2022 09:21

Correct the config name 'CONFIG_GRPC_XDS_SERVER_TLS_SAN'

192cd92

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

renuka-fernando mentioned this pull request Dec 6, 2022

Basic ADS client envoyproxy/go-control-plane#604

Merged

Merge branch 'main' of https://github.com/envoyproxy/ratelimit into x…

912864c

…ds-conf-provider-impl Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com> Conflicts: go.sum src/config/config_impl.go

github-actions Bot added the stale label Jan 12, 2023

Merge branch 'main' of https://github.com/envoyproxy/ratelimit into x…

5b55133

…ds-conf-provider-impl Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com> Conflicts: go.sum

github-actions Bot removed the stale label Jan 17, 2023

Update go-control-plane version which contains ADS Client implementation

f8f0e4a

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Update go-control-plane version which contains rate limit impl in sample

6ea0628

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

mattklein123 self-assigned this Feb 6, 2023

mattklein123 requested changes Feb 6, 2023

View reviewed changes

Comment thread examples/xds-sotw-config-server/logger.go Outdated

renuka-fernando added 2 commits February 7, 2023 08:33

Remove license headers

1873901

envoyproxy#373 (comment) Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Include rate limit config xDS proto

4f54625

Related to envoyproxy#371 Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

renuka-fernando requested a review from mattklein123 February 7, 2023 16:47

mattklein123 approved these changes Feb 7, 2023

View reviewed changes

mattklein123 merged commit 1a68686 into envoyproxy:main Feb 7, 2023

zirain mentioned this pull request Apr 4, 2023

ratelimit: switch to XdsGrpcSotwProvider envoyproxy/gateway#1254

Closed

barroca pushed a commit to barroca/ratelimit that referenced this pull request Sep 1, 2023

Dynamic config update via xDS Management Server (envoyproxy#373)

9457f59

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

akondapuram mentioned this pull request Jan 5, 2024

Add detailed_metric field to ratelimit descriptor envoyproxy/go-control-plane#841

Merged

timcovar pushed a commit to goatapp/ratelimit that referenced this pull request Jan 16, 2024

Dynamic config update via xDS Management Server (envoyproxy#373)

17e0776

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamic config update via xDS Management Server#373

Dynamic config update via xDS Management Server#373
mattklein123 merged 24 commits intoenvoyproxy:mainfrom
renuka-fernando:xds-conf-provider-impl

renuka-fernando commented Oct 25, 2022 •

edited

Loading

Uh oh!

carnei-ro commented Dec 9, 2022

Uh oh!

github-actions Bot commented Jan 12, 2023

Uh oh!

renuka-fernando commented Jan 27, 2023

Uh oh!

mattklein123 left a comment

Uh oh!

Uh oh!

mattklein123 left a comment

Uh oh!

collinlee commented Apr 1, 2023

Uh oh!

renuka-fernando commented Apr 2, 2023

Uh oh!

collinlee commented Apr 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

renuka-fernando commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Design

Tasks

Uh oh!

carnei-ro commented Dec 9, 2022

Uh oh!

github-actions Bot commented Jan 12, 2023

Uh oh!

renuka-fernando commented Jan 27, 2023

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

collinlee commented Apr 1, 2023

Uh oh!

renuka-fernando commented Apr 2, 2023

Uh oh!

collinlee commented Apr 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

renuka-fernando commented Oct 25, 2022 •

edited

Loading