Use _imaps._tcp.gmail.com in srv tests#375
Merged
Merged
Conversation
* Seeing tests failures in CI with the current SRV entry `_xmpp-server._tcp.gmail.com.` https://github.com/envoyproxy/ratelimit/actions/runs/3466737811/jobs/5802374477#step:3:257 * What is odd is I also tried `_xmpp-server._tcp.google.com.` which is used in the upstream `net.LookupSRV` tests https://cs.opensource.google/go/go/+/master:src/net/lookup_test.go;l=47;drc=2b59307ac21135ab8db58e08fb98211fbedbb10d?q=LookupSRV&ss=go%2Fgo but that failed as well Signed-off-by: Arko Dasgupta <arko@tetrate.io>
timcovar
pushed a commit
to goatapp/ratelimit
that referenced
this pull request
Jan 16, 2024
* Seeing tests failures in CI with the current SRV entry `_xmpp-server._tcp.gmail.com.` https://github.com/envoyproxy/ratelimit/actions/runs/3466737811/jobs/5802374477#step:3:257 * What is odd is I also tried `_xmpp-server._tcp.google.com.` which is used in the upstream `net.LookupSRV` tests https://cs.opensource.google/go/go/+/master:src/net/lookup_test.go;l=47;drc=2b59307ac21135ab8db58e08fb98211fbedbb10d?q=LookupSRV&ss=go%2Fgo but that failed as well Signed-off-by: Arko Dasgupta <arko@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing tests failures in CI with the current SRV entry
_xmpp-server._tcp.gmail.com.https://github.com/envoyproxy/ratelimit/actions/runs/3466737811/jobs/5802374477#step:3:257
What is odd is I also tried
_xmpp-server._tcp.google.com.which is used in the upstreamnet.LookupSRVtestshttps://cs.opensource.google/go/go/+/master:src/net/lookup_test.go;l=47;drc=2b59307ac21135ab8db58e08fb98211fbedbb10d?q=LookupSRV&ss=go%2Fgo but that failed as well
Signed-off-by: Arko Dasgupta arko@tetrate.io