fix: init gostats to not flood log#520
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Mar 27, 2024
Merged
Conversation
Default gostats store flood messages on stderr except if statd or if GOSTATS_LOGGING_SINK_DISABLED is set to "true". This commit init store in a unambiguous way. Signed-off-by: Guilhem Lettron <guilhem@barpilot.io>
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Contributor
Author
|
ping 🤷♂️ |
mattklein123
approved these changes
Mar 27, 2024
guilhem
added a commit
to guilhem/ratelimit
that referenced
this pull request
Mar 28, 2024
fix envoyproxy#520 trailing line
guilhem
added a commit
to guilhem/ratelimit
that referenced
this pull request
Mar 28, 2024
fix envoyproxy#520 trailing line
guilhem
added a commit
to guilhem/ratelimit
that referenced
this pull request
Mar 28, 2024
fix envoyproxy#520 trailing line Signed-off-by: Guilhem Lettron <guilhem@barpilot.io>
ysawa0
pushed a commit
that referenced
this pull request
Mar 29, 2024
fix #520 trailing line Signed-off-by: Guilhem Lettron <guilhem@barpilot.io>
This was referenced Apr 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default gostats store flood messages on stderr except if statd or if GOSTATS_LOGGING_SINK_DISABLED is set to "true". This commit init store in a unambiguous way.