feat: add support for weekly ratelimit unit#812
Merged
collin-lee merged 1 commit intoenvoyproxy:mainfrom Jan 11, 2025
Merged
Conversation
stefansedich
force-pushed
the
rls-weekly
branch
from
0d1ae01 to
1a80f4a
Compare
Signed-off-by: Stefan Sedich <stefan.sedich@gmail.com>
stefansedich
force-pushed
the
rls-weekly
branch
from
1a80f4a to
fd073e7
Compare
Contributor
Author
|
@collin-lee @arkodg would you be able to help me land this one? |
collin-lee
approved these changes
Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the weekly ratelimit unit which I added over in envoyproxy/envoy#37494 that has now been shipped in go-control-plane v0.13.2.