Skip to content

dependatool: Add NPM support#1374

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:dependatool-npm
Jan 3, 2024
Merged

dependatool: Add NPM support#1374
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:dependatool-npm

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Dec 27, 2023

No description provided.

@phlax phlax marked this pull request as draft December 27, 2023 16:17
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 27, 2023

Deploy Preview for nifty-bassi-e26446 ready!

Name Link
🔨 Latest commit 607f07d
🔍 Latest deploy log https://app.netlify.com/sites/nifty-bassi-e26446/deploys/658c504c3f44960008086a64
😎 Deploy Preview https://deploy-preview-1374--nifty-bassi-e26446.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jan 2, 2024

@mmorel-35 im in 2 minds about this - if we are moving to renovate i think its probably obsolete

@mmorel-35
Copy link
Copy Markdown
Collaborator

If renovate is doing the Job it is indeed going to be useless.
But in the meanwhile you can activate it if you know that there won't be any bad impact on your existing code ?

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jan 2, 2024

But in the meanwhile you can activate it if you know that there won't be any bad impact on your existing code ?

probably a good idea - it at least needs a bit of deployment testing

@phlax phlax changed the title [WIP] dependatool: Add NPM support dependatool: Add NPM support Jan 3, 2024
@phlax phlax marked this pull request as ready for review January 3, 2024 11:22
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jan 3, 2024

i tested this locally and seems to work - we can add proper tests if we decide to keep for some reason

@phlax phlax merged commit f5c7468 into envoyproxy:main Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants