Add realtime and systemtime getters. Preserve flags with operators.#52
Merged
eoyilmaz merged 4 commits intoeoyilmaz:developfrom Jan 17, 2024
Merged
Add realtime and systemtime getters. Preserve flags with operators.#52eoyilmaz merged 4 commits intoeoyilmaz:developfrom
eoyilmaz merged 4 commits intoeoyilmaz:developfrom
Conversation
Owner
|
Hey @cubicibo thank you for the PR, can you add tests related to what you have implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this MR is to add a mean to get the timestamps of a given SMPTE Timecode. Two timebases are considered:
to_systemtime()to_realtime()NTSC framerates will return different values as the system time is not aligned to the wall-clock time. All others should return the exact same value.
DF 29.97:
NDF 29.97:
PAL 50:
I did not implement setters as I don't think there's a meaningful usage or need to them.
Hopefully this may help others understand better Timecodes running at different rates and the relations to the wall-clock time.
The second commit is to preserve the drop frame flag on elementary operations.