Raise an exception when comparing instance with differing framerates#64
Merged
eoyilmaz merged 4 commits intoeoyilmaz:developfrom Jan 2, 2026
Merged
Conversation
|
+1 for this |
Use NotImplemented for undefined comparisons to unknown types to allow other classes the chance to provide an implementation Closes eoyilmaz#62 # Conflicts: # src/timecode/timecode.py # tests/test_timecode.py
nickswalker
force-pushed
the
deimplement-comparison
branch
from
8dce9ee to
0a516cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users should define their own semantics for comparing timecodes that have different framerates, and now they're forced to.
Use
NotImplementedfor undefined comparisons to unknown types to allow other classes the chance to provide an implementation. This allows other class authors to implement comparisons: https://docs.python.org/3/library/numbers.html#implementing-the-arithmetic-operationsCloses #62