Skip to content
This repository was archived by the owner on Jan 14, 2021. It is now read-only.

Bug/assortment of fixes#214

Open
epacke wants to merge 3 commits into
masterfrom
bug/assortment-of-fixes
Open

Bug/assortment of fixes#214
epacke wants to merge 3 commits into
masterfrom
bug/assortment-of-fixes

Conversation

@epacke
Copy link
Copy Markdown
Owner

@epacke epacke commented Jan 12, 2021

No description provided.

@epacke epacke requested a review from timriker January 12, 2021 14:13
@epacke
Copy link
Copy Markdown
Owner Author

epacke commented Jan 12, 2021

Solves #215

@timriker
Copy link
Copy Markdown
Collaborator

I'd recommend adding the temp file check back into MakeReleasePackage.ps1 with something like:

if(Test-Path "$ScriptFolder/underlay/json/preferences.json"){

So that if underlay is used as the ReportRoot, we don't accidentally include json files in the zip.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants