feat: initial release#1

Merged

roman-romanov-o merged 64 commits intodevelopmentfrom

feat/initial-release

Oct 14, 2024

roman-romanov-o commented Oct 8, 2024

Include such apis:

Bucket API
File API
Chat completions API
Deployments API
Applications API (without create)


          initial release, with chat completions, files, and limited apps API s…

fadf2ae

…upport

roman-romanov-o requested a review from adubovik

October 8, 2024 09:23

Roman Romanov added 4 commits

October 8, 2024 12:52


          update lockfile, try to fix pipeline

5a24d97


          fix makefile, one more attempt to fix pipeline

67bb3ae


          fix ort pipeline

c67a419


          add new account to code owners

37586e5

adubovik reviewed

View reviewed changes

pyproject.toml Outdated


          fix ort one more time

c646f81

adubovik reviewed

View reviewed changes

.github/CODEOWNERS Outdated

adubovik reviewed

View reviewed changes

pyproject.toml Outdated

adubovik reviewed

View reviewed changes

noxfile.py

adubovik reviewed

View reviewed changes

tests/test_auth.py

adubovik reviewed

View reviewed changes

noxfile.py Outdated

adubovik reviewed

View reviewed changes

noxfile.py Outdated

Roman Romanov added 2 commits

October 8, 2024 18:12


          fixes due to pr comments

1fcc22b


          remove examples from ort

863adb3

adubovik reviewed

View reviewed changes

aidial_client/_auth.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_auth.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_auth.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_auth.py

adubovik reviewed

View reviewed changes

aidial_client/_auth.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_constants.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_client.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_client.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_client.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_http_client/_base.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_client.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_client.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_client.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/_client.py Outdated

adubovik reviewed

View reviewed changes

tests/test_client_retry.py Outdated

adubovik reviewed

View reviewed changes

noxfile.py Outdated

Roman Romanov added 13 commits

October 11, 2024 19:01


          update noxfile to test lower version of aiofiles

fbeb565


          update noxfile one more time, remove few typing ignores

ae84bb0


          refactor appdata for client

436e07e


          narrow down allowed link in storage resource parser

d38844e


          naming refactor

b49005b


          add test for metadata

0b22a77


          Fix metadata, improve tests

bc127ca


          Fix naming of internal http client

d2d1e95


          Replace docstring with just comment

71822a1


          Refactor _my_appdata property, use NOT_GIVEN for it

64deba4


          Fix client pool test

21acd43


          Refine storage resource helpers, introduce new exception `NotDialURLE…

1457f55

…xception`


          More refactoring, fix minor bug with storage resource

3d35f36

roman-romanov-o requested a review from adubovik

October 14, 2024 09:09


          fix ort ignore rule

65da79b

adubovik reviewed

View reviewed changes

aidial_client/_client.py Outdated


          Minor refactor

90867df

adubovik reviewed

View reviewed changes

aidial_client/helpers/storage_resource.py Outdated

+                  """
+                  dial_api_url = enforce_trailing_slash(dial_api_url)
+                  if url.startswith("/"):
+                      return InvalidDialURLError(f"Relative root url is forbidden: {url}")

Collaborator

adubovik Oct 14, 2024

Root-relative URL is a more commonly used notion.

Author

roman-romanov-o Oct 14, 2024

Fixed

Collaborator

adubovik Oct 14, 2024 •

edited

Loading

Opt: it would be great to capitalize URL in all the user-facing error messages and doc strings.

It's visible to a client, so the wording is typically more formal than the text of regular source code comments.
It also provides more clarity and readability - it's easier to parse URL on the first glace than url, because we are so used to see it elsewhere.

Author

roman-romanov-o Oct 14, 2024

Fixed


          Refactor error naming

ca193a0

adubovik reviewed

View reviewed changes

aidial_client/helpers/storage_resource.py Outdated

adubovik reviewed

View reviewed changes

aidial_client/helpers/storage_resource.py

Roman Romanov added 2 commits

October 14, 2024 13:03


          refactor - make is_directory private

b2da8a6


          Refactor docstring

3839de3

adubovik approved these changes

View reviewed changes


          Refactor: capitalize url to URL in error message

6d3ad48

adubovik approved these changes

View reviewed changes

roman-romanov-o merged commit 59b293b into development

adubovik deleted the feat/initial-release branch

July 15, 2025 09:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet