Skip to content

Comments

Fix rotation units and keyframe interpolation in system prompt#20

Merged
epavanello merged 1 commit intomainfrom
claude/fix-rotation-units-prompt-XRuU8
Feb 14, 2026
Merged

Fix rotation units and keyframe interpolation in system prompt#20
epavanello merged 1 commit intomainfrom
claude/fix-rotation-units-prompt-XRuU8

Conversation

@epavanello
Copy link
Owner

@epavanello epavanello commented Feb 14, 2026

  • Change rotationZ display from degrees (°) to radians (rad) to match
    internal storage format (rotationZ is stored in radians, see schema
    and generateTransformCSS)
  • Replace nonexistent kf.easing with kf.interpolation.strategy to
    correctly show keyframe interpolation details

https://claude.ai/code/session_017bRZ5hzHh5nrLnKw4xwP7c

Summary by CodeRabbit

  • Bug Fixes
    • Updated keyframe detail formatting to consistently display interpolation strategy in output.
    • Changed rotation unit measurement from degrees to radians.

- Change rotationZ display from degrees (°) to radians (rad) to match
  internal storage format (rotationZ is stored in radians, see schema
  and generateTransformCSS)
- Replace nonexistent kf.easing with kf.interpolation.strategy to
  correctly show keyframe interpolation details

https://claude.ai/code/session_017bRZ5hzHh5nrLnKw4xwP7c
@epavanello epavanello merged commit 1a1e97d into main Feb 14, 2026
1 check was pending
@coderabbitai
Copy link

coderabbitai bot commented Feb 14, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The system prompt's formatting for keyframe details and layer transformations has been updated. Keyframe easing information now always appears in the serialized output rather than conditionally, and rotation measurements were converted from degrees to radians for consistency.

Changes

Cohort / File(s) Summary
System Prompt Formatting
src/lib/ai/system-prompt.ts
Updated keyframe detail formatting to always display interpolation strategy, and changed rotation units from degrees (°) to radians (rad).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Poem

🐰✨ Two tiny tweaks, but oh so keen,
Angles in radians now convene,
Easing always shows its face,
The prompt grows clearer, full of grace! 🎬

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/fix-rotation-units-prompt-XRuU8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants