Changes for Java9+ #2
Conversation
| <name>OSS Snapshots</name> | ||
| <url>https://oss.sonatype.org/content/repositories/snapshots</url> | ||
| </repository> | ||
| <!-- Temporary - needed for old snapshots of ChannelfinderAPI --> |
There was a problem hiding this comment.
Why remove this comment? It still applies.
There was a problem hiding this comment.
Well, if it still applies then it's not temporary?
There was a problem hiding this comment.
Let me explain.
The ChannelFinder API has changed. The only place where Maven can find the old versions is the deprecated EPICS repository on SourceForge.
As soon as the directoryService example has been updated to use the current API of ChannelFinder, the pointer to this deprecated repository should be removed.
Is that "temporary"? Do you have a better term?
There was a problem hiding this comment.
Then I think the comment should state what you just wrote. Plus the version numbers for the "old" and "current" ChannelFinder API.
|
In general, I prefer unrelated changes being in separate commits, but as in this case this is really minor, I will merge anyway. |
|
Thanks. |
Tweaks to pom file due to changed behaviour of the javadoc tool. A change in java source and target version is also needed to compile successfully.