We currently have a function remove_na_observed_predicted() that removes all rows where either predicted or observed is NA.
I think it would be good to simply replace this function by na.omit().
Reasoning:
- Having
NA values anywhere in the data (not just in observed and predicted) is potentially risky and could break things (e.g. mess up grouping according to the forecast unit). Handling this makes things more complicated.
na.omit() is a known function. Having (and exporting) a function that just removes NA values in certain columns seems unnecessarily complicated).
We currently have a function
remove_na_observed_predicted()that removes all rows where eitherpredictedorobservedisNA.I think it would be good to simply replace this function by
na.omit().Reasoning:
NAvalues anywhere in the data (not just inobservedandpredicted) is potentially risky and could break things (e.g. mess up grouping according to the forecast unit). Handling this makes things more complicated.na.omit()is a known function. Having (and exporting) a function that just removesNAvalues in certain columns seems unnecessarily complicated).