Issue #1005 - Update dependency on scoringRules to >=1.1.2 #1006
Merged
Conversation
seabbs
approved these changes
Jun 17, 2025
Contributor
seabbs
left a comment
There was a problem hiding this comment.
This looks good. Are you aware of any approaches to testing if we have this kind of dependency in the future? I am not so maybe we just need an issue to track?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #1005.
For scoring ordinal forecasts, we require functionality that was introduced in
scoringRules v1.1.2. This PR therefore updates the dependency accordingly,Checklist
lintr::lint_package()to check for style issues introduced by my changes.