Skip to content

Typos#109

Merged
nikosbosse merged 2 commits intomasterfrom
typos
Jun 21, 2021
Merged

Typos#109
nikosbosse merged 2 commits intomasterfrom
typos

Conversation

@Bisaloo
Copy link
Copy Markdown
Contributor

@Bisaloo Bisaloo commented Jun 4, 2021

Hi,

While reading the documentation to learn more about this package, I spotted a couple of typos so I run spelling::spell_check_package() and fixed them.

Please note that I could not rebuild README.md since the argument add_truth_data in scoringutils::plot_predictions() on L83 doesn't exist anymore. I think it has been renamed to truth_data but since I'm not sure, I didn't touch it.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 4, 2021

Codecov Report

Merging #109 (538e3e3) into master (8437a56) will not change coverage.
The diff coverage is n/a.

❗ Current head 538e3e3 differs from pull request most recent head e740fc2. Consider uploading reports for the commit e740fc2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   48.78%   48.78%           
=======================================
  Files          18       18           
  Lines        1355     1355           
=======================================
  Hits          661      661           
  Misses        694      694           
Impacted Files Coverage Δ
R/eval_forecasts.R 65.17% <ø> (ø)
R/eval_forecasts_continuous_integer.R 69.64% <ø> (ø)
R/metrics_point_forecasts.R 0.00% <ø> (ø)
R/pairwise-comparisons.R 42.14% <ø> (ø)
R/plot.R 0.00% <ø> (ø)
R/scoringRules_wrappers.R 46.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8437a56...e740fc2. Read the comment docs.

@nikosbosse
Copy link
Copy Markdown
Collaborator

Thank you very much for your support, that is really cool and much appreciated! I'm working on an update of the plot_predictions function and will check everything works fine.

Copy link
Copy Markdown
Collaborator

@nikosbosse nikosbosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nikosbosse nikosbosse merged commit 401f5a8 into master Jun 21, 2021
@Bisaloo Bisaloo deleted the typos branch June 21, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants