Skip to content

BOT: Fix #684: Delete unused check_input_sample/quantile/interval functions#1093

Draft
nikosbosse wants to merge 1 commit intomainfrom
fix/684-delete-check-input-functions
Draft

BOT: Fix #684: Delete unused check_input_sample/quantile/interval functions#1093
nikosbosse wants to merge 1 commit intomainfrom
fix/684-delete-check-input-functions

Conversation

@nikosbosse
Copy link
Collaborator

Summary

  • Deletes three unused internal functions: check_input_sample(), check_input_quantile(), and check_input_interval()
  • These were dead code — never called in production, only tested. A comment in check-input-helpers.R explicitly marks them for future deletion
  • Their assert_input_* counterparts remain and are used by all scoring functions

What was changed

  • R/metrics-sample.R: Removed check_input_sample() definition and roxygen block
  • R/metrics-quantile.R: Removed check_input_quantile() definition and roxygen block
  • R/metrics-interval-range.R: Removed check_input_interval() definition and roxygen block
  • man/: Deleted 3 corresponding .Rd files
  • Tests: Replaced old test blocks with tests confirming functions are removed + regression guards for assert_input_* + end-to-end scoring validation

Test plan

  • New "function no longer defined" tests verified to fail before deletion, pass after
  • Regression guard tests confirm assert_input_* functions still work correctly
  • End-to-end scoring functions work without check_input_* wrappers
  • Full test suite passes (683 tests, 0 failures)
  • R CMD check passes (0 errors, 0 warnings, 2 pre-existing notes)

Closes #684

🤖 Generated with Claude Code

These three internal functions were dead code — never called in production,
only tested. Their assert_input_* counterparts remain and are used by all
scoring functions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.82%. Comparing base (ac0c01a) to head (238a7d9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
- Coverage   97.83%   97.82%   -0.01%     
==========================================
  Files          35       35              
  Lines        1845     1837       -8     
==========================================
- Hits         1805     1797       -8     
  Misses         40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator Author

@nikosbosse nikosbosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLAUDE: Clean, minimal deletion of three unused internal check_input_* wrapper functions (check_input_sample, check_input_quantile, check_input_interval). All were dead code — never called in production, not exported, only tested. The assert_input_* counterparts are correctly preserved. check_try() is correctly left intact. Tests match all 7 specifications: removal confirmation, regression guards for assert_input_*, and end-to-end scoring validation. No scope creep. Verdict: approve.

@nikosbosse nikosbosse marked this pull request as draft February 13, 2026 08:28
@nikosbosse nikosbosse changed the title Fix #684: Delete unused check_input_sample/quantile/interval functions BOT: Fix #684: Delete unused check_input_sample/quantile/interval functions Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete functions check_input_sample(), check_input_quantile(), check_input_interval()

1 participant