BOT: Fix #684: Delete unused check_input_sample/quantile/interval functions#1093
Draft
nikosbosse wants to merge 1 commit intomainfrom
Draft
BOT: Fix #684: Delete unused check_input_sample/quantile/interval functions#1093nikosbosse wants to merge 1 commit intomainfrom
nikosbosse wants to merge 1 commit intomainfrom
Conversation
These three internal functions were dead code — never called in production, only tested. Their assert_input_* counterparts remain and are used by all scoring functions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1093 +/- ##
==========================================
- Coverage 97.83% 97.82% -0.01%
==========================================
Files 35 35
Lines 1845 1837 -8
==========================================
- Hits 1805 1797 -8
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nikosbosse
commented
Feb 13, 2026
Collaborator
Author
nikosbosse
left a comment
There was a problem hiding this comment.
CLAUDE: Clean, minimal deletion of three unused internal check_input_* wrapper functions (check_input_sample, check_input_quantile, check_input_interval). All were dead code — never called in production, not exported, only tested. The assert_input_* counterparts are correctly preserved. check_try() is correctly left intact. Tests match all 7 specifications: removal confirmation, regression guards for assert_input_*, and end-to-end scoring validation. No scope creep. Verdict: approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_input_sample(),check_input_quantile(), andcheck_input_interval()check-input-helpers.Rexplicitly marks them for future deletionassert_input_*counterparts remain and are used by all scoring functionsWhat was changed
R/metrics-sample.R: Removedcheck_input_sample()definition and roxygen blockR/metrics-quantile.R: Removedcheck_input_quantile()definition and roxygen blockR/metrics-interval-range.R: Removedcheck_input_interval()definition and roxygen blockman/: Deleted 3 corresponding.Rdfilesassert_input_*+ end-to-end scoring validationTest plan
assert_input_*functions still work correctlycheck_input_*wrappersR CMD checkpasses (0 errors, 0 warnings, 2 pre-existing notes)Closes #684
🤖 Generated with Claude Code