Skip to content

Remove unnecessary vapply()#120

Merged
nikosbosse merged 1 commit intomasterfrom
review-vapply
Aug 16, 2021
Merged

Remove unnecessary vapply()#120
nikosbosse merged 1 commit intomasterfrom
review-vapply

Conversation

@Bisaloo
Copy link
Copy Markdown
Contributor

@Bisaloo Bisaloo commented Jul 26, 2021

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 26, 2021

Codecov Report

Merging #120 (b465fa4) into master (de45fb7) will decrease coverage by 0.45%.
The diff coverage is 100.00%.

❗ Current head b465fa4 differs from pull request most recent head 129bd40. Consider uploading reports for the commit 129bd40 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   48.85%   48.40%   -0.46%     
==========================================
  Files          18       18              
  Lines        1357     1345      -12     
==========================================
- Hits          663      651      -12     
  Misses        694      694              
Impacted Files Coverage Δ
R/bias.R 87.93% <100.00%> (-1.14%) ⬇️
R/pit.R 56.09% <100.00%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de45fb7...129bd40. Read the comment docs.

@Bisaloo Bisaloo mentioned this pull request Jul 27, 2021
53 tasks
@Bisaloo Bisaloo marked this pull request as ready for review July 27, 2021 14:26
Copy link
Copy Markdown
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so much cleaner!

Copy link
Copy Markdown
Collaborator

@nikosbosse nikosbosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@nikosbosse nikosbosse merged commit d09ff23 into master Aug 16, 2021
@nikosbosse nikosbosse deleted the review-vapply branch August 16, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants