Skip to content

add print method to pkgdown yaml#162

Merged
nikosbosse merged 2 commits intomasterfrom
add-check-function
Nov 25, 2021
Merged

add print method to pkgdown yaml#162
nikosbosse merged 2 commits intomasterfrom
add-check-function

Conversation

@nikosbosse
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 25, 2021

Codecov Report

Merging #162 (9620485) into master (d364378) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   54.56%   54.56%           
=======================================
  Files          19       19           
  Lines        1468     1468           
=======================================
  Hits          801      801           
  Misses        667      667           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9626189...9620485. Read the comment docs.

@nikosbosse nikosbosse requested a review from Bisaloo November 25, 2021 11:35
@nikosbosse
Copy link
Copy Markdown
Collaborator Author

Is that a good way to do it for S3 methods?

@Bisaloo
Copy link
Copy Markdown
Contributor

Bisaloo commented Nov 25, 2021

I would put it in the same category as check_forecasts(). Especially since it's not a super useful S3 method (as mentioned, it's likely that many users will not realise you're even using S3 here).

@seabbs
Copy link
Copy Markdown
Contributor

seabbs commented Nov 25, 2021

I've been using the @family and @context tags fairly extensively to automate this and quite like it.

@nikosbosse nikosbosse merged commit 3f23387 into master Nov 25, 2021
@nikosbosse nikosbosse deleted the add-check-function branch November 25, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants