Merged
Conversation
Update branch with newest version of check_forecasts function
Update branch with latest version of check function... again...
update branch from master
Merge branch 'simplify-eval-forecasts' of https://github.com/epiforecasts/scoringutils into simplify-eval-forecasts # Conflicts: # R/pit.R # man/pit.Rd # man/pit_df.Rd
rename sharpness to dispersion
reduce the number of arguments to eval_forecasts()
get rid of verbose argument in most instances
eliminate by argument by requiring users to only include relevant columns
replace list of arguments for interval_score by ...
remove PIT plots from eval_forecasts()
remove summarised argument and always summarise (users can just pass in every column to summarise_by to avoid any summary taking place.
simplify code for PIT values by
returning PIT values rather than p-values from an Anderson-Darling test
creating a version that works on a data.frame and returns a list that can then get passed to plotting function
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 54.56% 56.68% +2.11%
==========================================
Files 19 22 +3
Lines 1468 1362 -106
==========================================
- Hits 801 772 -29
+ Misses 667 590 -77
Continue to review full report at Codecov.
|
Bisaloo
reviewed
Mar 11, 2022
Bisaloo
reviewed
Mar 17, 2022
Co-authored-by: Hugo Gruson <Bisaloo@users.noreply.github.com>
Contributor
|
🥳 |
This was referenced Mar 24, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature updates
can easily be piped and have simplified arguments and outputs.
new functions and function changes
eval_forecastswas replaced by a function [score()] with amuch reduced set of function arguments.
to a function [summarise_scores()]
intervals
forecasts
plot_pitfunctionwas renamed to [pit_sample()]. PIT p-values were removed entirely.
restricted to sample-based, quantile-based or binary forecasts.
the mean before returning an output.
package data updated
(https://covid19forecasthub.eu/).
example_summary_metricswas included that contains a summary of themetrics implemented in
scoringutilsOther breaking changes
dispersion. This was done to make it more clear what the component represents
and to maintain consistency with what is used in other places.