Skip to content

Add docker + vscode support#177

Merged
seabbs merged 1 commit intomasterfrom
feature-add-vscode-docker
Feb 3, 2022
Merged

Add docker + vscode support#177
seabbs merged 1 commit intomasterfrom
feature-add-vscode-docker

Conversation

@seabbs
Copy link
Copy Markdown
Contributor

@seabbs seabbs commented Feb 3, 2022

This PR adds a docker container (with alll dependencies etc + vscode dev tools) based on a rocker image.

It also adds a github action to build this docker image and vscode config options to make spinning up a dev box easier (+ support for codespaces).

This would all make my life easier but might also be nice for others. Very optional though as obvious has no impact on the core code.

@seabbs seabbs requested a review from nikosbosse February 3, 2022 14:32
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2022

Codecov Report

Merging #177 (c1d5be7) into master (3f23387) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   54.56%   54.56%           
=======================================
  Files          19       19           
  Lines        1468     1468           
=======================================
  Hits          801      801           
  Misses        667      667           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f23387...c1d5be7. Read the comment docs.

@nikosbosse
Copy link
Copy Markdown
Collaborator

looks good. So it builds a container whenever it pushes something and then you can just use that container for your dev work? And it will only have the master branch?

@seabbs
Copy link
Copy Markdown
Contributor Author

seabbs commented Feb 3, 2022

Yes exactly on all of those.

@seabbs seabbs merged commit 4f583a5 into master Feb 3, 2022
@seabbs seabbs deleted the feature-add-vscode-docker branch February 3, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants