Skip to content

Fix separate results #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikosbosse merged 4 commits into from
Jul 9, 2022
Merged

Fix separate results #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be165db
fix the way separate_results gets passed to score_quantile
nikosbosse Jul 9, 2022
62a5e30
update roxygen version
nikosbosse Jul 9, 2022
78b5703
add unit test for quantile_score fix
nikosbosse Jul 9, 2022
6cfd533
update documentation
nikosbosse Jul 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Config/Needs/website:
r-lib/pkgdown,
amirmasoudabdol/preferably
Config/testthat/edition: 3
RoxygenNote: 7.1.2
RoxygenNote: 7.2.0
URL: https://epiforecasts.io/scoringutils/, https://github.com/epiforecasts/scoringutils
BugReports: https://github.com/epiforecasts/scoringutils/issues
VignetteBuilder: knitr
Expand Down
2 changes: 1 addition & 1 deletion R/score_quantile.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ score_quantile <- function(data,
list(true_value, lower,
upper, range,
weigh,
separate_results = TRUE
separate_results = separate_results
)
)]
}
Expand Down
2 changes: 1 addition & 1 deletion man/scoringutils-package.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions tests/testthat/test-score.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,22 @@ test_that("function produces output for a quantile format case", {
)
})

test_that("score_quantile correctly handles separate results = FALSE", {
quantile_example <- data.table::setDT(scoringutils::example_quantile)
eval <- suppressMessages(
score(
quantile_example[!is.na(prediction)],
separate_results = FALSE
)
)

expect_equal(
nrow(eval) > 1,
TRUE
)
})


test_that("score() quantile produces desired metrics", {
data <- data.frame(
true_value = rep(1:10, each = 2),
Expand Down