Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 22 22
Lines 1361 1361
=======================================
Hits 1243 1243
Misses 118 118
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sbfnk
approved these changes
Sep 16, 2022
R/plot.R
Outdated
| aes(x = pit_value) | ||
| ) + | ||
| geom_histogram(aes(y = stat(count) / sum(count)), | ||
| geom_histogram(aes(y = stat(width*density)), |
Contributor
There was a problem hiding this comment.
it looks good but really should have a space around the *
Contributor
|
You should add a news item, too (with a new version 1.0.0.2000). |
nikosbosse
commented
Oct 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbfnk can you please have a quick look to confirm that this is correct now?