Merged
Conversation
seabbs
added
documentation
seabbs
force-pushed
the
seabbs/issue248
branch
from
1f38bd7 to
0bb263e
Compare
nikosbosse
reviewed
Jan 12, 2023
Collaborator
nikosbosse
left a comment
nikosbosse
left a comment
There was a problem hiding this comment.
Really nice, thanks a lot!
nikosbosse
approved these changes
Jan 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 91.33% 91.36% +0.02%
==========================================
Files 21 21
Lines 1362 1366 +4
==========================================
+ Hits 1244 1248 +4
Misses 118 118
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
I changed to testing with some tolerance as a workaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #248 by depreciating
metricinsummarise_scores()in favour ofrelative_skill_metric(). In order to do this robustly I have added a new dependency on thelifecyclepackage.I have added tests of this change as well as adding tests for the relative skill functionality of
summarise_scores(). I have checked all uses ofmetricin the documentation to check they are up to date and updated as required.