Docmentation: update score and related documentation to mention the model column#260
Merged
nikosbosse merged 2 commits intomasterfrom Jan 13, 2023
Merged
Docmentation: update score and related documentation to mention the model column#260nikosbosse merged 2 commits intomasterfrom
nikosbosse merged 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=======================================
Coverage 91.36% 91.36%
=======================================
Files 21 21
Lines 1366 1366
=======================================
Hits 1248 1248
Misses 118 118
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #232 by making the
modelcolumn soft requirement clear. In addition it fleshes out the documentation for score and links thedataargument with the other places it is used (i.echeck_forecasts()).Making the
dataargument be inherited fromscoredoes flag that the documentaton was a litle misleading in parts for some functions. I think this should be addressed in another PR vs here.