simplify plot_pairwise_comparison()#263
Merged
nikosbosse merged 4 commits intomasterfrom Jan 18, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
- Coverage 91.39% 90.80% -0.59%
==========================================
Files 21 21
Lines 1371 1284 -87
==========================================
- Hits 1253 1166 -87
Misses 118 118
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
Author
|
need to fix the failing tests first, apologies... |
seabbs
reviewed
Jan 17, 2023
Collaborator
Author
|
@seabbs Ready now :) |
seabbs
reviewed
Jan 17, 2023
| plot_pairwise_comparison <- function(comparison_result, | ||
| type = c("mean_scores_ratio", "pval", "together"), | ||
| smaller_is_good = TRUE) { | ||
| type = c("mean_scores_ratio", "pval")) { |
Contributor
There was a problem hiding this comment.
match.arg to check allowed options used.
Collaborator
Author
There was a problem hiding this comment.
It does use match.arg in line 782 - is that different from what you meant?
Contributor
There was a problem hiding this comment.
For type? If it does then no that is exactly what I meant
seabbs
approved these changes
Jan 17, 2023
Contributor
seabbs
left a comment
seabbs
left a comment
There was a problem hiding this comment.
LGTM to me. I've suggested you use match.arg to check the input for type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the function by removing the option to plot both pvalues and mean score ratios together.