Skip to content

tweak code samples to avoid issues with CRAN#266

Merged
nikosbosse merged 2 commits intomasterfrom
cran-update
Feb 27, 2023
Merged

tweak code samples to avoid issues with CRAN#266
nikosbosse merged 2 commits intomasterfrom
cran-update

Conversation

@nikosbosse
Copy link
Copy Markdown
Collaborator

Sets number of threads to 1 for examples

@nikosbosse nikosbosse requested a review from seabbs January 31, 2023 17:58
@nikosbosse
Copy link
Copy Markdown
Collaborator Author

Hm curious... this does not fail on my local machine.. Will investigate

@nikosbosse
Copy link
Copy Markdown
Collaborator Author

nikosbosse commented Feb 17, 2023

still confused.. @Bisaloo do you maybe have an idea? It seems like the snapshot review fails, but there is nothing that I can update on my local machine. Potentially related to: r-lib/vdiffr#117

@seabbs
Copy link
Copy Markdown
Contributor

seabbs commented Feb 17, 2023

I can look at this later but we have a solution for the original problem in EpiNow2 I think

@seabbs
Copy link
Copy Markdown
Contributor

seabbs commented Feb 17, 2023

As a test does the vdiffr issue happen for any PR or just this one?

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2023

Codecov Report

Merging #266 (a70c0e4) into master (692b8bb) will not change coverage.
The diff coverage is n/a.

❗ Current head a70c0e4 differs from pull request most recent head 899927c. Consider uploading reports for the commit 899927c to get more accurate results

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files          21       21           
  Lines        1284     1284           
=======================================
  Hits         1166     1166           
  Misses        118      118           
Impacted Files Coverage Δ
R/avail_forecasts.R 100.00% <ø> (ø)
R/pairwise-comparisons.R 87.30% <ø> (ø)
R/pit.R 77.35% <ø> (ø)
R/plot.R 97.52% <ø> (ø)
R/score.R 100.00% <ø> (ø)
R/summarise_scores.R 89.74% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nikosbosse
Copy link
Copy Markdown
Collaborator Author

apparently this was due to an outdated version of an upstream package on my machine. Updated, recreated the plots, updated the snapshots and now works like a charm

@nikosbosse nikosbosse merged commit 70ecd47 into master Feb 27, 2023
@Bisaloo Bisaloo deleted the cran-update branch February 27, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants