Add a transform_forecasts() function#278
Merged
nikosbosse merged 18 commits intomasterfrom Apr 11, 2023
Merged
Conversation
…out adding anything
…ws taking the log with an offset
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 90.82% 90.55% -0.27%
==========================================
Files 21 22 +1
Lines 1286 1324 +38
==========================================
+ Hits 1168 1199 +31
- Misses 118 125 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal is very similar to #271, with the only difference that the
log_shift()function has nonegative_to_zeroargument. This seemed somewhat controversial, so this PR introduces the maintransform_forecasts()function and we can think about adding the function argument at a later time.