Skip to content

Add warning interval score#281

Merged
nikosbosse merged 4 commits intomasterfrom
add_warning_interval_score
Apr 19, 2023
Merged

Add warning interval score#281
nikosbosse merged 4 commits intomasterfrom
add_warning_interval_score

Conversation

@nikosbosse
Copy link
Copy Markdown
Collaborator

Add warning to interval score if the interval range looks wrong as discussed in #277

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2023

Codecov Report

Merging #281 (82d6358) into master (aef47ec) will decrease coverage by 0.33%.
The diff coverage is 28.57%.

❗ Current head 82d6358 differs from pull request most recent head 7484bdc. Consider uploading reports for the commit 7484bdc to get more accurate results

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   90.55%   90.23%   -0.33%     
==========================================
  Files          22       22              
  Lines        1324     1331       +7     
==========================================
+ Hits         1199     1201       +2     
- Misses        125      130       +5     
Impacted Files Coverage Δ
R/interval_score.R 84.44% <28.57%> (-10.30%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and seems like a sensible check in the first instance whilst we consider redefining as @adrian-lison suggested (that discussion likely needs to be ported to an issue).

@nikosbosse nikosbosse merged commit 836bc0f into master Apr 19, 2023
@nikosbosse nikosbosse deleted the add_warning_interval_score branch April 19, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants