Skip to content

Edit pass on transform_forecasts and NEWS#283

Merged
seabbs merged 2 commits intomasterfrom
seabbs/transform_forecasts-docs
Apr 19, 2023
Merged

Edit pass on transform_forecasts and NEWS#283
seabbs merged 2 commits intomasterfrom
seabbs/transform_forecasts-docs

Conversation

@seabbs
Copy link
Copy Markdown
Contributor

@seabbs seabbs commented Apr 19, 2023

This PR performs an edit pass on the documentation for transform_forecasts() and the NEWS file.

For the news this is mainly standardising formatting along with a few spelling corrections.

For transform_forecasts() I have cleaned up a few formatting issues and expanded some of the text to try and make it very clear what is happening. I have also added head() calls to reduce the lenght of the rendered examples in the web docs (as these were quite long and hard to pass (at least for me)).

@seabbs seabbs requested a review from nikosbosse April 19, 2023 10:21
@seabbs seabbs marked this pull request as ready for review April 19, 2023 10:21
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2023

Codecov Report

Merging #283 (54f7354) into master (aef47ec) will not change coverage.
The diff coverage is n/a.

❗ Current head 54f7354 differs from pull request most recent head 931450a. Consider uploading reports for the commit 931450a to get more accurate results

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files          22       22           
  Lines        1324     1324           
=======================================
  Hits         1199     1199           
  Misses        125      125           
Impacted Files Coverage Δ
R/convenience-functions.R 81.57% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Collaborator

@nikosbosse nikosbosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good. Thank you!

Co-authored-by: Nikos Bosse <37978797+nikosbosse@users.noreply.github.com>
@seabbs seabbs merged commit ebdfc6c into master Apr 19, 2023
@seabbs seabbs deleted the seabbs/transform_forecasts-docs branch April 19, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants