fix quantile/sample mixup in vignette#308
Merged
nikosbosse merged 3 commits intomainfrom Jul 25, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 22 22
Lines 1377 1377
=======================================
Hits 1235 1235
Misses 142 142 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This will make it appear as a separate "Get Started" item in the pkgdown navbar.
nikosbosse
approved these changes
Jul 25, 2023
Collaborator
nikosbosse
left a comment
nikosbosse
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Contributor
|
Flagging this PR was missing a news + dev version update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #306.
This also renames the introductory vignette so it appears as a separate navbar item "Get Started". I think this is preferable but happy to revert if people disagree.
I have fixed linting issues where changing files has caused them to be flagged.