Skip to content

Replace use of ".Rda" by use of ".rds" where appropriate#318

Merged
nikosbosse merged 4 commits intoscoringutils-reviewfrom
scoringutils-review1
Sep 4, 2023
Merged

Replace use of ".Rda" by use of ".rds" where appropriate#318
nikosbosse merged 4 commits intoscoringutils-reviewfrom
scoringutils-review1

Conversation

@nikosbosse
Copy link
Copy Markdown
Collaborator

This PR addresses one of the issues raised by a recent review of the package as part of a submission to the Journal of Statistical Software (JSS).

It replaces the use of ".Rda" by the use of ".rds" where before ".Rda" was sometimes used in conjunction with saveRDS().

@nikosbosse nikosbosse requested a review from seabbs September 3, 2023 16:27
@nikosbosse
Copy link
Copy Markdown
Collaborator Author

@seabbs not sure what the best way to deal with multiple small PRs in a row.. I'm trying to save us all from a mega PR so I'm splitting everything up in smaller PRs. But I assume we don't want to update the version number 1293812 times? Also happy to make PRs directly to main if you prefer.

Copy link
Copy Markdown
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikosbosse nikosbosse merged commit 2a6d555 into scoringutils-review Sep 4, 2023
@nikosbosse nikosbosse deleted the scoringutils-review1 branch September 4, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants