Skip to content

Replace ..density.. by after_stat(density)#319

Merged
nikosbosse merged 3 commits intoscoringutils-reviewfrom
scoringutils-review2
Sep 4, 2023
Merged

Replace ..density.. by after_stat(density)#319
nikosbosse merged 3 commits intoscoringutils-reviewfrom
scoringutils-review2

Conversation

@nikosbosse
Copy link
Copy Markdown
Collaborator

This PR addresses one of the issues raised by a recent review of the package as part of a submission to the Journal of Statistical Software (JSS).

The ..density.. notation is deprecated in ggplot2 and this PR replaces it by after_stat(density)

Copy link
Copy Markdown
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikosbosse nikosbosse merged commit 3679c99 into scoringutils-review Sep 4, 2023
@nikosbosse nikosbosse deleted the scoringutils-review2 branch September 4, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants