Improvements to avail_forecasts() --> available_forecasts()#321
Merged
nikosbosse merged 9 commits intoscoringutils-reviewfrom Sep 5, 2023
Merged
Improvements to avail_forecasts() --> available_forecasts()#321nikosbosse merged 9 commits intoscoringutils-reviewfrom
nikosbosse merged 9 commits intoscoringutils-reviewfrom
Conversation
…lable_forecasts() and plot_available_forecasts()
…ilable_forecasts()`
Create an S3 method for plot_avail_forecasts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses one of the issues raised by a recent review of the package as part of a submission to the Journal of Statistical Software (JSS).
It
avail_forecasts()toavailable_forecasts()for consistency withavailable_metrics(). The old function,avail_forecasts()is still available as an alias, but will be removed in the future.avail_forecasts()from "Number forecasts" to "count".available_forecasts()to display combinations where there are 0 forecasts, instead of silently dropping corresponding rows.plot()that replacesplot_avail_forecasts(). The old function is still available, but is deprecated.I think the suggestion to include combinations with 0 forecasts is a good one as it makes it very clear that no forecasts are available and users can always drop those rows afterwards.