Update bias_quantile() to work with vectors / matrices instead of data.table#396
Merged
nikosbosse merged 2 commits intorework-add_coverage()from Nov 15, 2023
Merged
Conversation
Merged
seabbs
approved these changes
Nov 15, 2023
Contributor
seabbs
left a comment
seabbs
left a comment
There was a problem hiding this comment.
These PRs are obviously a bit of a mess and make any kind of formal review very hard.
I'd suggest making a single PR with a proposed feature change here in anyway that you want.
Base automatically changed from
rework-score.quantile()
to
rework-add_coverage()
November 15, 2023 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverses some of the changes made in #388. In particular, it changes
bias_quantile()again such that it works with vectors / matrices instead of data.table. This increases speed and makes the function more consistent with other functions.If it makes reviewing things easier I can also merge this one into #388 (although there are some updates in between) or I could replicate the changes I made here in #388.