Merged
Conversation
seabbs
approved these changes
Nov 15, 2023
Contributor
seabbs
left a comment
seabbs
left a comment
There was a problem hiding this comment.
Phew. I was deeply committed to only moving files around in this PR. This is hard!
I hope there is someone annoying at the people for me to vent on... :)
Otherwise all LGTM
Base automatically changed from
rework-score.scoringutils_quantile()2
to
add-coverage-deviation
November 15, 2023 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves tests around such that the structure of the test files follows the structure of the actual function R files more closely.
Also a very minor fix in
score.scoringutils_quantile()(removing code to delete a column that doesn't exist) and make minimal changes to binary tests. Phew. I was deeply committed to only moving files around in this PR. This is hard!