Merged
Conversation
…cause we can't pass the `forecast_unit` arg to apply_metrics
This was referenced Nov 14, 2023
Base automatically changed from
reword-add_coverage2
to
add-coverage-deviation
November 15, 2023 17:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies
score()a bit by introducing a new function,apply_metrics()that takes care of applying all metrics.The function evaluates an expression. One question to think about: should this expression be inside or outside the function? Having it inside makes the rest of the code clearer. Having it outside allows for more customisability.
Another downside of the current approach is that it is difficult to do things e.g. by
forecast_unit. The way this is handled currently is that a matrix is constructed based on the data for quantile and sample-based forecasts (this is helpful for speed reasons).This PR closes #398 and also #429 as
run_safely()now runs withinscore()