Skip to content

Issues #402: Expose get_forecast_unit() to users#464

Merged
nikosbosse merged 4 commits intodevelopfrom
expose-functions
Nov 20, 2023
Merged

Issues #402: Expose get_forecast_unit() to users#464
nikosbosse merged 4 commits intodevelopfrom
expose-functions

Conversation

@nikosbosse
Copy link
Copy Markdown
Collaborator

Closes #402

As discussed in #402, this PR

  • exposes get_forecast_unit() to users as it might be useful for model diagnostics
  • adds some tests for it

@nikosbosse nikosbosse changed the base branch from dev-backup to dev November 18, 2023 15:38
Fix failing CI issues by deleting code remnants that shouldn't be there anymore
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@4df4576). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #464   +/-   ##
==========================================
  Coverage           ?   80.67%           
==========================================
  Files              ?       20           
  Lines              ?     1713           
  Branches           ?        0           
==========================================
  Hits               ?     1382           
  Misses             ?      331           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

seabbs

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine

@nikosbosse nikosbosse merged commit 1a730f4 into develop Nov 20, 2023
@nikosbosse nikosbosse deleted the expose-functions branch November 20, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants