Issue #427: Fix error in set_forecast_unit() that occurs when input is not a data.table#487
Merged
nikosbosse merged 5 commits intomainfrom Nov 25, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
=======================================
Coverage 90.91% 90.92%
=======================================
Files 23 23
Lines 1398 1399 +1
=======================================
+ Hits 1271 1272 +1
Misses 127 127 ☔ View full report in Codecov by Sentry. |
seabbs
approved these changes
Nov 24, 2023
Contributor
seabbs
left a comment
There was a problem hiding this comment.
I'd really rather this had a unit test and merge issues were dealt with but its better to get this fixed than not at all.
seabbs
reviewed
Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #427
set_forecast_unit()currently fails when the input is adata.frame()instead of adata.table(). This PR hotfixes the issue by making sure by callingas.data.table()on the input.There exists also a more complete fix including tests and more thorough input checks in #437 that have already been reviewed and merged into the development branch. It would have been more ideal to target that PR to main instead of develop, but given that has already happened I think it is best to make a quick fix here. I ran the tests from the already reviewed PR here as well to make sure everything is working as expected, but didn't replicate them to avoid further merge conflicts due to variable names changing between main and dev.
Not ideal, apologies, will target main with future fixes like this one.