Issue #480: Update to R version 3.6 to fix failing gh action#488
Merged
nikosbosse merged 2 commits intomainfrom Nov 20, 2023
Merged
Issue #480: Update to R version 3.6 to fix failing gh action#488nikosbosse merged 2 commits intomainfrom
nikosbosse merged 2 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 22 22
Lines 1392 1392
=======================================
Hits 1265 1265
Misses 127 127 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
@Bisaloo please excuse that I'm pinging you again on this one - this is essentially the same PR you were already so kind to review and approve. Could you formally approve it again please so I can merge it into main? Thank you! |
Bisaloo
approved these changes
Nov 20, 2023
Collaborator
Author
|
Merci! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tracks changes made in #483 (apart from the added NEWS item), but targets them at main instead of the development branch. The version targeted at the develop branch has already been reviewed and approved.
Fixes #480
As discussed in #480, Github action checks for R 3.5 are currently failing. This is because some packages that scoringutils imports or suggests depend on R >= 3.6.
This PR