Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #509 +/- ##
========================================
Coverage 81.21% 81.21%
========================================
Files 20 20
Lines 1725 1725
========================================
Hits 1401 1401
Misses 324 324 ☔ View full report in Codecov by Sentry. |
seabbs
approved these changes
Nov 28, 2023
Contributor
seabbs
left a comment
There was a problem hiding this comment.
Definitely looks better. I think shortening the name is fine. Still failing as its flagging all the lines that are new and don't have test coverage.
Collaborator
Author
|
I think I addressed all your comments. Are you happy for me to merge? In particular, should we address tests in a different PR, or would you prefer doing this now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #485
This PR fixes linting issues on the current development branch. It
Two single items stand out:
interval_coverage_deviation_quantileis too longplot.scoringutils_available_forecastsis too longWe could simply change
interval_coverage_deviation_quantiletointerval_coverage_dev_quantile(exactly 30 chars long). An alternative would be to simply exclude the line from linting.The second one is related to #403.
Update 1 I created a second PR for the name of
plot.scoringutils_available_forecasts(), #511, which addresses #403Update 2 I renamed the function to
interval_coverage_dev_quantileChecklist
I have added or updated unit tests where necessary.I have updated the documentation if required.lintr::lint_package()to check for style issues introduced by my changes.I have added a news item linked to this PR.