Issue 486: Fix NOTEs for CRAN submission#514
Merged
nikosbosse merged 6 commits intomainfrom Nov 29, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
=======================================
Coverage 90.92% 90.92%
=======================================
Files 23 23
Lines 1399 1399
=======================================
Hits 1272 1272
Misses 127 127 ☔ View full report in Codecov by Sentry. |
seabbs
reviewed
Nov 29, 2023
seabbs
reviewed
Nov 29, 2023
R/summarise_scores.R
Outdated
| #' summary is present according to the value specified in `by`. | ||
| #' @examples | ||
| #' library(magrittr) # pipe operator | ||
| #' data.table::setDTthreads(1) # only needed to avoid issues on CRAN |
Contributor
There was a problem hiding this comment.
why not using the same core count and dontshow everywhere?
seabbs
approved these changes
Nov 29, 2023
Contributor
seabbs
left a comment
seabbs
left a comment
There was a problem hiding this comment.
Nearly.
- Setting cores to 2 is not what is recommended in that thread but will work and makes sense.
- Can we be consistent with setting the number of cores and if we show that to users
- Suggest update the comment to be a bit more neutral
seabbs
reviewed
Nov 29, 2023
Collaborator
Author
|
this was the recommendation that I used: Rdatatable/data.table#5658 (comment)
You're right, I updated the code |
Collaborator
Author
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #486
During CRAN submission, we got a Note on one of CRAN's machines that CPU time > elapsed time for some examples, tests, and the vignette- this is usually the case when more than 2 cores are used. We had that issue in the past and is almost certainly linked to
data.table(see Rdatatable/data.table#3300 and Rdatatable/data.table#5658).To "solve" this I added the line
data.table::setDTthreads(2)before offending code. This is what was suggested in Rdatatable/data.table#5658 by thedata.tablemaintainers.(The PR also makes a single unrelated linting fix in the vignette)
Checklist
I have added or updated unit tests where necessary.I have updated the documentation if required.lintr::lint_package()to check for style issues introduced by my changes.I have added a news item linked to this PR.