Issue #275: Fix handling of scalar inputs in logs_binary()#524
Merged
nikosbosse merged 1 commit intodevelopfrom Dec 11, 2023
Merged
Issue #275: Fix handling of scalar inputs in logs_binary()#524nikosbosse merged 1 commit intodevelopfrom
logs_binary()#524nikosbosse merged 1 commit intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #524 +/- ##
========================================
Coverage 81.21% 81.21%
========================================
Files 20 20
Lines 1725 1725
========================================
Hits 1401 1401
Misses 324 324 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #275.
Ideally we would like
logs_binary()to be able to accept a single value as an input that then gets recycled just like any other vector in R does. The current implementation had anifelse()statement there which did work for several observed values and a single predicted value, but not the other way round.This PR updates the code in
logs_binary()to work with scalar values and adds tests against the functionll()from theMetricspackage to verify everything is correct.Checklist
I have updated the documentation if required.lintr::lint_package()to check for style issues introduced by my changes.I have added a news item linked to this PR.