Issue 555: Rename interval_coverage_ family and remove sample version#558
Merged
nikosbosse merged 7 commits intodevelopfrom Jan 5, 2024
Merged
Issue 555: Rename interval_coverage_ family and remove sample version#558nikosbosse merged 7 commits intodevelopfrom
nikosbosse merged 7 commits intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #558 +/- ##
===========================================
+ Coverage 84.55% 85.14% +0.59%
===========================================
Files 21 21
Lines 1722 1710 -12
===========================================
Hits 1456 1456
+ Misses 266 254 -12 ☔ View full report in Codecov by Sentry. |
nikosbosse
approved these changes
Jan 5, 2024
Collaborator
nikosbosse
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #555.
It removes
interval_coverage_sample()and renamesinterval_coverage_quantile()andinterval_coverage_dev_quantile()tointerval_coverage()andinterval_coverage_deviation().Note that I have stored some of the useful helper code from
interval_coverage_sample()in #557By removing
interval_coverage_sample()this PR also closes #411.Checklist
lintr::lint_package()to check for style issues introduced by my changes.