Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 21 21
Lines 1711 1711
=======================================
Hits 1457 1457
Misses 254 254 ☔ View full report in Codecov by Sentry. |
nikosbosse
approved these changes
Jan 6, 2024
Collaborator
nikosbosse
left a comment
There was a problem hiding this comment.
Good idea, I like this. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #563 @sbfnk introduced new functionality to post users at the alternative version of the docs to the one they are currently viewing. However, if they are not on the HTML docs then there is currently no link to the current version of the HTML docs that they are looking at. It could be nice if this were the case.
This PR adds this. I think worth some discussion to check it makes sense .
Checklist
lintr::lint_package()to check for style issues introduced by my changes.